Re: [Intel-gfx] [v2, 1/4] drm/i915/huc: drop intel_huc_is_authenticated

[Teres Alexis, Alan Previn]

Reviewed-by: Alan Previn <alan.previn.teres.ale...@intel.com>

On Wed, 2022-05-04 at 13:48 -0700, Daniele Ceraolo Spurio wrote:
> The fuction name is confusing, because it doesn't check the actual auth
> status in HW but the SW status. Given that there is only one user (the
> huc_auth function itself), just get rid of it and use the FW status
> checker directly.
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 +-
>  drivers/gpu/drm/i915/gt/uc/intel_huc.h | 5 -----
>  2 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c 
> b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> index 556829de9c172..7b759b99cf3c8 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> @@ -96,7 +96,7 @@ int intel_huc_auth(struct intel_huc *huc)
>       struct intel_guc *guc = &gt->uc.guc;
>       int ret;
>  
> -     GEM_BUG_ON(intel_huc_is_authenticated(huc));
> +     GEM_BUG_ON(intel_uc_fw_is_running(&huc->fw));
>  
>       if (!intel_uc_fw_is_loaded(&huc->fw))
>               return -ENOEXEC;
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.h 
> b/drivers/gpu/drm/i915/gt/uc/intel_huc.h
> index 73ec670800f2b..77d813840d76c 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.h
> @@ -50,11 +50,6 @@ static inline bool intel_huc_is_used(struct intel_huc *huc)
>       return intel_uc_fw_is_available(&huc->fw);
>  }
>  
> -static inline bool intel_huc_is_authenticated(struct intel_huc *huc)
> -{
> -     return intel_uc_fw_is_running(&huc->fw);
> -}
> -
>  void intel_huc_load_status(struct intel_huc *huc, struct drm_printer *p);
>  
>  #endif