On Tue, Nov 12, 2013 at 11:58:08PM +0000, Chris Wilson wrote: > On Tue, Nov 12, 2013 at 02:53:08PM -0800, Jesse Barnes wrote: > > Preallocated, stolen objects will already be added to this list when we > > first create them. > > That had me scratching my head a bit trying to work out where and why > stolen objects were explicitly adding themselves to the obj->vma_list. > > "Preallocated objects will already have been added to the vma_list when > creating their ggtt vma entry, and coincidentally also marked as holding > a ggtt mapping. Repeating the vma_list manipulation when setting up the > ggtt after preallocation is a recipe for an unhappy kernel."
Agreed. > > > > > Signed-off-by: Jesse Barnes <[email protected]> > Reviewed-by: Chris Wilson <[email protected]> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
