== Series Details ==
Series: Tidy up vfio_device life cycle (rev2)
URL : https://patchwork.freedesktop.org/series/107838/
State : warning
== Summary ==
Error: dim checkpatch failed
405257a130f0 vfio: Add helpers for unifying vfio_device life cycle
-:69: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#69: FILE: drivers/vfio/vfio_main.c:512:
+struct vfio_device *_vfio_alloc_device(size_t size, struct device *dev,
+ const struct vfio_device_ops *ops)
-:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_struct' - possible
side-effects?
#189: FILE: include/linux/vfio.h:147:
+#define vfio_alloc_device(dev_struct, member, dev, ops)
\
+ container_of(_vfio_alloc_device(sizeof(struct dev_struct) +
\
+ BUILD_BUG_ON_ZERO(offsetof(
\
+ struct dev_struct, member)),
\
+ dev, ops),
\
+ struct dev_struct, member)
-:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible
side-effects?
#189: FILE: include/linux/vfio.h:147:
+#define vfio_alloc_device(dev_struct, member, dev, ops)
\
+ container_of(_vfio_alloc_device(sizeof(struct dev_struct) +
\
+ BUILD_BUG_ON_ZERO(offsetof(
\
+ struct dev_struct, member)),
\
+ dev, ops),
\
+ struct dev_struct, member)
total: 0 errors, 0 warnings, 3 checks, 147 lines checked
df0991d343cd vfio/pci: Use the new device life cycle helpers
43ddd4b3b4eb vfio/mlx5: Use the new device life cycle helpers
-:21: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#21: FILE: drivers/vfio/pci/mlx5/main.c:584:
+ struct mlx5vf_pci_core_device *mvdev = container_of(
-:33: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#33: FILE: drivers/vfio/pci/mlx5/main.c:596:
+
+}
-:37: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#37: FILE: drivers/vfio/pci/mlx5/main.c:600:
+ struct mlx5vf_pci_core_device *mvdev = container_of(
total: 0 errors, 0 warnings, 3 checks, 74 lines checked
e4bb5c47eaf7 vfio/hisi_acc: Use the new device life cycle helpers
f5c7d76e8b8f vfio/mdpy: Use the new device life cycle helpers
ac90d6a82ba1 vfio/mtty: Use the new device life cycle helpers
c3540147339d vfio/mbochs: Use the new device life cycle helpers
73067e42b2dd drm/i915/gvt: Use the new device life cycle helpers
-:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#155: FILE: drivers/gpu/drm/i915/gvt/vgpu.c:365:
+static int __intel_gvt_create_vgpu(struct intel_vgpu *vgpu,
struct intel_vgpu_creation_params *param)
total: 0 errors, 0 warnings, 1 checks, 197 lines checked
dd517d04b701 vfio/ap: Use the new device life cycle helpers
291765af61e2 vfio/fsl-mc: Use the new device life cycle helpers
910cf1cc7e4e vfio/platform: Use the new device life cycle helpers
1e4453d1c194 vfio/amba: Use the new device life cycle helpers
ce8562ac714a vfio/ccw: Use the new device life cycle helpers
45939f17c91c vfio: Rename vfio_device_put() and vfio_device_try_get()
212d729dc851 vfio: Add struct device to vfio_device
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#15:
> > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the
-:48: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#48:
new file mode 100644
-:60: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 2 warnings, 0 checks, 8 lines checked
