> -----Original Message-----
> From: De Marchi, Lucas <[email protected]>
> Sent: Thursday, September 29, 2022 5:11 PM
> To: Sripada, Radhakrishna <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH v4.1] drm/i915/mtl: Define engine context layouts
>
> On Wed, Sep 28, 2022 at 08:55:11AM -0700, Radhakrishna Sripada wrote:
> >From: Matt Roper <[email protected]>
> >
> >The part of the media and blitter engine contexts that we care about for
> >setting up an initial state on MTL are nearly similar to DG2 (and PVC).
> >The difference being PRT_BB_STATE being replaced with NOP.
> >
> >For render/compute engines, the part of the context images are nearly
> >the same, although the layout had a very slight change --- one POSH
> >register was removed and the placement of some LRI/noops adjusted
> >slightly to compensate.
> >
> >v2:
> > - Dg2, mtl xcs offsets slightly vary. Use a separate offsets array(Bala)
> > - Add missing nop in xcs offsets(Bala)
> >v3:
> > - Fix the spacing for nop in xcs offset(MattR)
> >v4:
> > - Fix rcs register offset(MattR)
> >v4.1:
> > - Fix commit message(Lucas)
> >
> >Bspec: 46261, 46260, 45585
> >Cc: Balasubramani Vivekanandan <[email protected]>
> >Cc: Licas De Marchi <[email protected]>
> >Signed-off-by: Matt Roper <[email protected]>
> >Signed-off-by: Radhakrishna Sripada <[email protected]>
>
>
> Reviewed-by: Lucas De Marchi <[email protected]>
Pushed the patch, Thanks for the review.
-Radhakrishna Sripada
>
> Lucas De Marchi
