Re: [Intel-gfx] [PATCH v2] drm/i915: Print return value on error

[Andrzej Hajda]

On 14.10.2022 17:46, Nirmoy Das wrote:

Print returned error code for better debuggability.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/7211
Signed-off-by: Nirmoy Das <nirmoy....@intel.com>

Reviewed-by: Andrzej Hajda <andrzej.ha...@intel.com>

Regards
Andrzej

---
  drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c 
b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 112aa0447a0d..ab385d18ddcc 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -175,7 +175,7 @@ static int intelfb_alloc(struct drm_fb_helper *helper,
        }

if (IS_ERR(obj)) {

-               drm_err(&dev_priv->drm, "failed to allocate framebuffer\n");
+               drm_err(&dev_priv->drm, "failed to allocate framebuffer 
(%pe)\n", obj);
                return PTR_ERR(obj);
        }

@@ -256,7 +256,7 @@ static int intelfb_create(struct drm_fb_helper *helper, info = drm_fb_helper_alloc_fbi(helper);

        if (IS_ERR(info)) {
-               drm_err(&dev_priv->drm, "Failed to allocate fb_info\n");
+               drm_err(&dev_priv->drm, "Failed to allocate fb_info (%pe)\n", 
info);
                ret = PTR_ERR(info);
                goto out_unpin;
        }
@@ -291,7 +291,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
        vaddr = i915_vma_pin_iomap(vma);
        if (IS_ERR(vaddr)) {
                drm_err(&dev_priv->drm,
-                       "Failed to remap framebuffer into virtual memory\n");
+                       "Failed to remap framebuffer into virtual memory 
(%pe)\n", vaddr);
                ret = PTR_ERR(vaddr);
                goto out_unpin;
        }