Simple regression test for lmem to check if an in-progress async unbind and eviction is syncronised with discarding the pages when marking the object as DONTNEED.
v2: Convert into new test to avoid damaging other test when forcing the lmem_size and unloading the driver. Signed-off-by: Matthew Auld <[email protected]> Cc: Niranjana Vishwanathapura <[email protected]> Cc: Andrzej Hajda <[email protected]> Cc: Nirmoy Das <[email protected]> Reviewed-by: Nirmoy Das <[email protected]> --- tests/i915/gem_lmem_evict.c | 138 ++++++++++++++++++++++++++++++++++++ tests/meson.build | 1 + 2 files changed, 139 insertions(+) create mode 100644 tests/i915/gem_lmem_evict.c diff --git a/tests/i915/gem_lmem_evict.c b/tests/i915/gem_lmem_evict.c new file mode 100644 index 00000000..71a066de --- /dev/null +++ b/tests/i915/gem_lmem_evict.c @@ -0,0 +1,138 @@ +// SPDX-License-Identifier: MIT +/* + * Copyright © 2022 Intel Corporation + */ + +#include "igt.h" +#include "igt_kmod.h" +#include "i915/gem_create.h" +#include "i915/gem.h" + +IGT_TEST_DESCRIPTION("Force tiny lmem size for easily testing eviction scenarios."); + +#define PAGE_SIZE 4096 + +static uint32_t batch_create_size(int fd, uint64_t size) +{ + const uint32_t bbe = MI_BATCH_BUFFER_END; + uint32_t handle; + + handle = gem_create(fd, size); + gem_write(fd, handle, 0, &bbe, sizeof(bbe)); + + return handle; +} + +static int upload(int fd, uint32_t handle) +{ + struct drm_i915_gem_exec_object2 exec[2] = {}; + struct drm_i915_gem_execbuffer2 execbuf = { + .buffers_ptr = to_user_pointer(&exec), + .buffer_count = 2, + }; + + exec[0].handle = handle; + exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS; + exec[1].handle = batch_create_size(fd, PAGE_SIZE); + exec[1].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS; + + gem_execbuf(fd, &execbuf); + return 0; +} + +static void test_dontneed_evict_race(int fd, + struct gem_memory_region *region) +{ + const uint64_t size = region->size >> 1; + uint64_t ahnd = get_reloc_ahnd(fd, 0); + uint32_t handle1; + igt_spin_t *spin; + + handle1 = gem_create_in_memory_region_list(fd, size, 0, + ®ion->ci, 1); + spin = igt_spin_new(fd, + .ahnd = ahnd, + .dependency = handle1); + + igt_fork(child, 1) { + uint32_t handle2; + + fd = gem_reopen_driver(fd); + + handle2 = gem_create_in_memory_region_list(fd, + size, 0, + ®ion->ci, 1); + /* + * The actual move when evicting will be pipelined + * behind the spinner, so can't fire until the spinner + * is killed. + */ + upload(fd, handle2); + gem_close(fd, handle2); + } + + sleep(2); /* Give eviction time to find handle1 */ + igt_spin_end(spin); + gem_madvise(fd, handle1, I915_MADV_DONTNEED); + igt_waitchildren(); + + igt_spin_free(fd, spin); + gem_close(fd, handle1); +} + +igt_main +{ + struct drm_i915_query_memory_regions *regions; + int i915 = -1; + + igt_fixture { + char *tmp; + + if (igt_kmod_is_loaded("i915")) { + i915 = __drm_open_driver(DRIVER_INTEL); + igt_require_fd(i915); + igt_require_gem(i915); + igt_require(gem_has_lmem(i915)); + close(i915); + } + + igt_i915_driver_unload(); + /* + * To avoid running of ring space and stalling during evicting + * (while holding the dma-resv lock), we need to use a smaller + * lmem size, such we can easliy trigger eviction without + * needing to wait for more ring space. The point of the test is + * to mark the object as DONTNEED which has an in-progress + * pipilined unbind/move, which also requires grabbing the + * dma-resv lock. + */ + igt_assert_eq(igt_i915_driver_load("lmem_size=128"), 0); + + i915 = __drm_open_driver(DRIVER_INTEL); + igt_require_fd(i915); + igt_require_gem(i915); + igt_require(gem_has_lmem(i915)); + + tmp = __igt_params_get(i915, "lmem_size"); + igt_skip_on(!tmp); + free(tmp); + + regions = gem_get_query_memory_regions(i915); + igt_require(regions); + } + + igt_describe("Regression test to verify that madvise will sync against busy dma-resv object for lmem"); + igt_subtest("dontneed-evict-race") { + for_each_memory_region(r, i915) { + if (r->ci.memory_class == I915_MEMORY_CLASS_DEVICE) { + test_dontneed_evict_race(i915, r); + break; + } + } + } + + igt_fixture { + close(i915); + igt_i915_driver_unload(); + } +} diff --git a/tests/meson.build b/tests/meson.build index 12e53e0b..5c052e73 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -160,6 +160,7 @@ i915_progs = [ 'gem_gtt_speed', 'gem_huc_copy', 'gem_linear_blits', + 'gem_lmem_evict', 'gem_lmem_swapping', 'gem_lut_handle', 'gem_madvise', -- 2.38.1
