Re: [Intel-gfx] [PATCH 1/2] drm: Add SDP Error Detection Configuration Register

[Harry Wentland]

On 1/12/23 23:36, Arun R Murthy wrote:
> DP2.0 E11 defines a new register to facilitate SDP error detection by a
> 128B/132B capable DPRX device.
> 
> Signed-off-by: Arun R Murthy <arun.r.mur...@intel.com>
> ---
>  include/drm/display/drm_dp.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index 9bc22a02874d..8bf6f0a60c38 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -691,6 +691,9 @@
>  # define DP_FEC_LANE_2_SELECT                    (2 << 4)
>  # define DP_FEC_LANE_3_SELECT                    (3 << 4)
>  
> +#define DP_SDP_ERROR_DETECTION                   0x121       /* DP 2.0 E11 */

If we're sticking with copying the exact naming from the DP spec
this might be more correctly be named DP_SDP_ERROR_DETECTION_CONFIGURATION

Harry

> +#define DP_SDP_CRC16_128B132B_EN         BIT(0)
> +
>  #define DP_AUX_FRAME_SYNC_VALUE                  0x15c   /* eDP 1.4 */
>  # define DP_AUX_FRAME_SYNC_VALID         (1 << 0)
>