On Wed, Jan 11, 2023 at 03:55:30PM -0800, Radhakrishna Sripada wrote: > Communicating QGV points restriction to PUnit happens via PM Demand > instead of the Pcode mailbox in the previous platforms. GV point > restriction is handled by the PM demand code.
This sounds correct, but it would probably be better to include this in a patch series where PM Demand support is added; this patch doesn't really make much sense without that additional context. Matt > > Signed-off-by: Radhakrishna Sripada <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_bw.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c > b/drivers/gpu/drm/i915/display/intel_bw.c > index 1c236f02b380..6791b25eb72d 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -124,6 +124,9 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private > *dev_priv, > { > int ret; > > + if (DISPLAY_VER(dev_priv) >= 14) > + return 0; > + > /* bspec says to keep retrying for at least 1 ms */ > ret = skl_pcode_request(&dev_priv->uncore, > ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, > points_mask, > -- > 2.34.1 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
