From: Ville Syrjälä <[email protected]>

Currently we just print a debug message if the ELD is bogus.
Maybe we should just not enable audio at all in that case?

Cc: Chaitanya Kumar Borah <[email protected]>
Cc: Takashi Iwai <[email protected]>
Reviewed-by: Kai Vehmanen <[email protected]>
Signed-off-by: Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_audio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_audio.c 
b/drivers/gpu/drm/i915/display/intel_audio.c
index 326e93768687..5123bab17063 100644
--- a/drivers/gpu/drm/i915/display/intel_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_audio.c
@@ -757,10 +757,12 @@ bool intel_audio_compute_config(struct intel_encoder 
*encoder,
        const struct drm_display_mode *adjusted_mode =
                &crtc_state->hw.adjusted_mode;
 
-       if (!connector->eld[0])
+       if (!connector->eld[0]) {
                drm_dbg_kms(&i915->drm,
                            "Bogus ELD on [CONNECTOR:%d:%s]\n",
                            connector->base.id, connector->name);
+               return false;
+       }
 
        BUILD_BUG_ON(sizeof(crtc_state->eld) != sizeof(connector->eld));
        memcpy(crtc_state->eld, connector->eld, sizeof(crtc_state->eld));
-- 
2.39.1

Reply via email to