Re: [Intel-gfx] [PATCH 2/2] drm/i915: Replace wm.max_levels with wm.num_levels and use it everywhere

[Ville Syrjälä]

On Thu, Feb 09, 2023 at 05:40:14PM +0200, Jani Nikula wrote:
> On Thu, 09 Feb 2023, Ville Syrjala <ville.syrj...@linux.intel.com> wrote:
> > @@ -3229,7 +3216,7 @@ static void ilk_wm_merge(struct drm_i915_private 
> > *dev_priv,
> >     merged->fbc_wm_enabled = DISPLAY_VER(dev_priv) >= 6;
> >  
> >     /* merge each WM1+ level */
> > -   for (level = 1; level <= max_level; level++) {
> > +   for (level = 1; level < num_levels - 1; level++) {
> 
> That's off by one, right?

Whoops. Good eyes.

-- 
Ville Syrjälä
Intel