> -----Original Message----- > From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Thomas > Zimmermann > Sent: tiistai 28. helmikuuta 2023 17.46 > To: Dmitry Osipenko <dmitry.osipe...@collabora.com>; > maarten.lankho...@linux.intel.com; airl...@gmail.com; dan...@ffwll.ch; Nikula, > Jani <jani.nik...@intel.com> > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to > reservation lock" > > Hi > > Am 28.02.23 um 16:28 schrieb Dmitry Osipenko: > > On 2/28/23 18:26, Thomas Zimmermann wrote: > >> This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. > >> > >> The locking appears incomplete. A caller of SHMEM helper's pin > >> function never acquires the dma-buf reservation lock. So we get > >> > >> WARNING: CPU: 3 PID: 967 at > >> drivers/gpu/drm/drm_gem_shmem_helper.c:243 > >> drm_gem_shmem_pin+0x42/0x90 [drm_shmem_helper] > >> > >> Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de> > >> --- > > > > Thanks Thomas, > > > > Acked-by: Dmitry Osipenko <dmitry.osipe...@collabora.com> > > > > Thanks, merged now. I hope this fixes the immediate issues. According to pre-merge results: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114478v1/index.html? So should fix.
> > Best regards > Thomas > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Ivo Totev