On Mon, 27 Mar 2023, Rodrigo Vivi <[email protected]> wrote: > On Mon, Mar 27, 2023 at 01:53:30PM +0300, Jani Nikula wrote: >> Essentially this is a revert of commit d9d54a530a70 ("drm/i915: Put >> future HW and their uAPIs under STAGING & BROKEN"). >> >> We currently have no users for this config option. The last one was >> removed in 8c26491f5853 ("drm/i915: Kill the fake lmem support"). Drop >> it altogether; it's easy enough to resurrect if need arises. >> >> Cc: Joonas Lahtinen <[email protected]> >> Cc: Rodrigo Vivi <[email protected]> >> Cc: Tvrtko Ursulin <[email protected]> >> Signed-off-by: Jani Nikula <[email protected]> > > Reviewed-by: Rodrigo Vivi <[email protected]>
Thanks for the review, pushed this one to drm-intel-next, and dropped the commit being reverted in patch 1/2 from core-for-CI. BR, Jani. > >> --- >> drivers/gpu/drm/i915/Kconfig | 6 ------ >> drivers/gpu/drm/i915/Kconfig.unstable | 21 --------------------- >> 2 files changed, 27 deletions(-) >> delete mode 100644 drivers/gpu/drm/i915/Kconfig.unstable >> >> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig >> index 98f4e44976e0..06a0ca157e89 100644 >> --- a/drivers/gpu/drm/i915/Kconfig >> +++ b/drivers/gpu/drm/i915/Kconfig >> @@ -164,11 +164,5 @@ menu "drm/i915 Profile Guided Optimisation" >> source "drivers/gpu/drm/i915/Kconfig.profile" >> endmenu >> >> -menu "drm/i915 Unstable Evolution" >> - visible if EXPERT && STAGING && BROKEN >> - depends on DRM_I915 >> - source "drivers/gpu/drm/i915/Kconfig.unstable" >> -endmenu >> - >> config DRM_I915_GVT >> bool >> diff --git a/drivers/gpu/drm/i915/Kconfig.unstable >> b/drivers/gpu/drm/i915/Kconfig.unstable >> deleted file mode 100644 >> index cf151a297ed7..000000000000 >> --- a/drivers/gpu/drm/i915/Kconfig.unstable >> +++ /dev/null >> @@ -1,21 +0,0 @@ >> -# SPDX-License-Identifier: GPL-2.0-only >> -config DRM_I915_UNSTABLE >> - bool "Enable unstable API for early prototype development" >> - depends on EXPERT >> - depends on STAGING >> - depends on BROKEN # should never be enabled by distros! >> - # We use the dependency on !COMPILE_TEST to not be enabled in >> - # allmodconfig or allyesconfig configurations >> - depends on !COMPILE_TEST >> - default n >> - help >> - Enable prototype uAPI under general discussion before they are >> - finalized. Such prototypes may be withdrawn or substantially >> - changed before release. They are only enabled here so that a wide >> - number of interested parties (userspace driver developers) can >> - verify that the uAPI meet their expectations. These uAPI should >> - never be used in production. >> - >> - Recommended for driver developers _only_. >> - >> - If in the slightest bit of doubt, say "N". >> -- >> 2.39.2 >> -- Jani Nikula, Intel Open Source Graphics Center
