On Mon, 26 Jun 2023, Chaitanya Kumar Borah <[email protected]> wrote: > With change [1], visibility of struct seq_file is lost in > intel_display_power.h leading to build errors. Add header > file explicitly to restore visibility. > > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration") > > Signed-off-by: Chaitanya Kumar Borah <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_display_power.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h > b/drivers/gpu/drm/i915/display/intel_display_power.h > index be1a87bde0c9..888993079a7b 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.h > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h > @@ -6,6 +6,8 @@ > #ifndef __INTEL_DISPLAY_POWER_H__ > #define __INTEL_DISPLAY_POWER_H__ > > +#include <linux/seq_file.h> > +
Always prefer a forward declaration over an include when it's sufficient. BR, Jani. > #include "intel_wakeref.h" > > enum aux_ch; -- Jani Nikula, Intel Open Source Graphics Center
