> This function is only used locally, so make it static and remove the 
> definition
> from the header file.
> 
> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

LGTM 

Reviewed-by: Suraj Kandpal <suraj.kand...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
> drivers/gpu/drm/i915/display/intel_tc.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c
> b/drivers/gpu/drm/i915/display/intel_tc.c
> index 71bbc2b16a0e..de848b329f4b 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -260,7 +260,7 @@ assert_tc_port_power_enabled(struct intel_tc_port
> *tc)
>                   !intel_display_power_is_enabled(i915,
> tc_port_power_domain(tc)));  }
> 
> -u32 intel_tc_port_get_lane_mask(struct intel_digital_port *dig_port)
> +static u32 intel_tc_port_get_lane_mask(struct intel_digital_port
> +*dig_port)
>  {
>       struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
>       struct intel_tc_port *tc = to_tc_port(dig_port); diff --git
> a/drivers/gpu/drm/i915/display/intel_tc.h
> b/drivers/gpu/drm/i915/display/intel_tc.h
> index 3b16491925fa..ffc0e2a74e43 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.h
> +++ b/drivers/gpu/drm/i915/display/intel_tc.h
> @@ -19,7 +19,6 @@ bool intel_tc_port_in_legacy_mode(struct
> intel_digital_port *dig_port);  bool intel_tc_port_connected(struct
> intel_encoder *encoder);  bool intel_tc_port_connected_locked(struct
> intel_encoder *encoder);
> 
> -u32 intel_tc_port_get_lane_mask(struct intel_digital_port *dig_port);
>  u32 intel_tc_port_get_pin_assignment_mask(struct intel_digital_port
> *dig_port);  int intel_tc_port_fia_max_lane_count(struct intel_digital_port
> *dig_port);  void intel_tc_port_set_fia_lane_count(struct intel_digital_port
> *dig_port,
> --
> 2.39.2

Reply via email to