On 9/14/2023 3:03 PM, Balasubrawmanian, Vivaik wrote:
On 9/13/2023 3:57 PM, Alan Previn wrote:
Debugging PXP issues can't even begin without understanding precedding
sequence of events. Add drm_dbg into the most important PXP events.
v2 : - remove __func__ since drm_dbg covers that (Jani).
- add timeout of the restart from front-end (Alan).
Signed-off-by: Alan Previn <[email protected]>
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 ++
drivers/gpu/drm/i915/pxp/intel_pxp.c | 15 ++++++++++++---
drivers/gpu/drm/i915/pxp/intel_pxp_irq.c | 4 ++--
drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 6 +++++-
drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 1 +
5 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
index 5f138de3c14f..61216c4abaec 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
@@ -321,6 +321,7 @@ static int i915_gsc_proxy_component_bind(struct
device *i915_kdev,
mutex_lock(&gsc->proxy.mutex);
gsc->proxy.component = data;
gsc->proxy.component->mei_dev = mei_kdev;
+ gt_dbg(gt, "GSC proxy mei component bound\n");
mutex_unlock(&gsc->proxy.mutex);
<snip>
Can we move the debug print to outside the mutex block?
review complete conditional to the above fix.
Reviewed-by: Balasubrawmanian, Vivaik
<[email protected]>
<mailto:[email protected]>
<snip>
base-commit: 45460a37f9be43072b509ca6044b215648f56221
