Hi Jonathan, kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-i915-Add-WABB-blit-for-Wa_16018031267-Wa_16018063123/20230922-024907 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230921183729.3763860-2-jonathan.cavitt%40intel.com patch subject: [Intel-gfx] [PATCH v13 1/2] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 config: i386-randconfig-141-20230925 (https://download.01.org/0day-ci/archive/20230925/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230925/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ New smatch warnings: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4181 guc_kernel_context_pin() error: uninitialized symbol 'ret'. vim +/ret +4181 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4153 static inline int guc_kernel_context_pin(struct intel_guc *guc, 3a4cdf1982f05d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Matthew Brost 2021-07-21 4154 struct intel_context *ce) 3a4cdf1982f05d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Matthew Brost 2021-07-21 4155 { cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4156 int ret; Please set "ret = 0;" here to avoid an uninitialized variable. cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4157 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4158 /* 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4159 * Note: we purposefully do not check the returns below because 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4160 * the registration can only fail if a reset is just starting. 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4161 * This is called at the end of reset so presumably another reset 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4162 * isn't happening and even it did this code would be run again. 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4163 */ 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4164 cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4165 if (context_guc_id_invalid(ce)) { cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4166 ret = pin_guc_id(guc, ce); cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4167 cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4168 if (ret < 0) cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4169 return ret; cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4170 } 58ea7d620c5ebc drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-03-01 4171 de51de9672a17e drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-11-02 4172 if (!test_bit(CONTEXT_GUC_INIT, &ce->flags)) de51de9672a17e drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-11-02 4173 guc_context_init(ce); de51de9672a17e drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2022-11-02 4174 72d46c25c5d83e drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Jonathan Cavitt 2023-09-21 4175 if (!intel_context_is_hidden(ce)) { cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4176 ret = try_context_registration(ce, true); cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4177 if (ret) cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4178 unpin_guc_id(guc, ce); 72d46c25c5d83e drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Jonathan Cavitt 2023-09-21 4179 } cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 4180 cd414f4f59f64d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c John Harrison 2023-02-17 @4181 return ret; 3a4cdf1982f05d drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c Matthew Brost 2021-07-21 4182 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
