On Mon, 09 Oct 2023, Ville Syrjala <[email protected]> wrote:
> From: Ville Syrjälä <[email protected]>
>
> VLV was missed when the color.get_config() hook was added.
> Remedy that.

Oops, how did I manage that?! Thanks for the fix,

Reviewed-by: Jani Nikula <[email protected]>

> Not really sure what the final plan here was since a bunch of
> color related readout was left in intel_display.c anyway,
> but that's for anothr day to figure out...

I guess I just wanted to start somewhere, and the cutoff was mostly by
the registers where the data is read from, e.g. ->gamma_mode and
->wgc_enable coming from TRANSCONF I left in place.

BR,
Jani.

>
> Cc: Jani Nikula <[email protected]>
> Fixes: 9af09dfcdfa1 ("drm/i915/color: move pre-SKL gamma and CSC enable read 
> to intel_color")
> Signed-off-by: Ville Syrjälä <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_color.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c 
> b/drivers/gpu/drm/i915/display/intel_color.c
> index 4f92fc31059f..2a2a163ea652 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -3702,6 +3702,7 @@ static const struct intel_color_funcs vlv_color_funcs = 
> {
>       .read_luts = i965_read_luts,
>       .lut_equal = i965_lut_equal,
>       .read_csc = vlv_read_csc,
> +     .get_config = i9xx_get_config,
>  };
>  
>  static const struct intel_color_funcs i965_color_funcs = {

-- 
Jani Nikula, Intel

Reply via email to