Hi Andi,

On 10/14/2023 10:51 AM, Andi Shyti wrote:
Hi Nirmoy,

On Fri, Oct 13, 2023 at 03:44:39PM +0200, Nirmoy Das wrote:
gen8_ggtt_invalidate() is only needed for limited set of platforms
where GGTT is mapped as WC otherwise this can cause unwanted
side-effects on XE_HP platforms where GFX_FLSH_CNTL_GEN6 is not
valid.

v2: Add a func to detect wc ggtt detection (Ville)

Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")
Cc: Rodrigo Vivi <[email protected]>
Cc: Tvrtko Ursulin <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Jonathan Cavitt <[email protected]>
Cc: John Harrison <[email protected]>
Cc: Andi Shyti <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Cc: <[email protected]> # v6.2+
Suggested-by: Matt Roper <[email protected]>
Signed-off-by: Nirmoy Das <[email protected]>
Acked-by: Andi Shyti <[email protected]>
I took some time to look at this and you can swap the a-b with
an r-b:

Reviewed-by: Andi Shyti <[email protected]>

Thanks! Going to resend one more rev with commit that is started using this register for WC mapping.


Regards,

Nirmoy


Thanks,
Andi

Reply via email to