Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply notify_guc to all GTs

[Nirmoy Das]

On 11/6/2023 1:45 PM, Jani Nikula wrote:
On Wed, 25 Oct 2023, Nirmoy Das <nirmoy....@intel.com> wrote:
Handle platforms with multiple GTs by iterate over all GTs.
Add a Fixes commit so this gets propagated for MTL support.

Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'force_probe' requirement for Meteor 
Lake")
This came up in another patch. I don't like abusing Fixes: like this. I
understand the motivation here, but this patch does not fix the
referenced commit.

I wasn't aware of a better solution but now I have from your response to 
the other patch.

I will keep that in my mind.


Thanks,

Nirmoy


BR,
Jani.

Suggested-by: John Harrison <john.c.harri...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com>
Cc: Andi Shyti <andi.sh...@linux.intel.com>
Cc: Andrzej Hajda <andrzej.ha...@intel.com>
Signed-off-by: Nirmoy Das <nirmoy....@intel.com>
---
  drivers/gpu/drm/i915/i915_debugfs_params.c | 9 ++++++---
  1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c 
b/drivers/gpu/drm/i915/i915_debugfs_params.c
index 614bde321589..8bca02025e09 100644
--- a/drivers/gpu/drm/i915/i915_debugfs_params.c
+++ b/drivers/gpu/drm/i915/i915_debugfs_params.c
@@ -38,10 +38,13 @@ static int i915_param_int_open(struct inode *inode, struct 
file *file)
  
  static int notify_guc(struct drm_i915_private *i915)
  {
-       int ret = 0;
+       struct intel_gt *gt;
+       int i, ret = 0;
  
-	if (intel_uc_uses_guc_submission(&to_gt(i915)->uc))
-               ret = intel_guc_global_policies_update(&to_gt(i915)->uc.guc);
+       for_each_gt(gt, i915, i) {
+               if (intel_uc_uses_guc_submission(&gt->uc))
+                       ret = intel_guc_global_policies_update(&gt->uc.guc);
+       }
  
  	return ret;
  }