On Mon, 13 Nov 2023, Tvrtko Ursulin <[email protected]> wrote:
> From: Tvrtko Ursulin <[email protected]>
>
> __rcu annotation is needed to avoid the sparse warnings such as:
>
>   .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in 
> comparison expression (different address spaces):
>   .../i915_drm_client.c:92:9: sparse:    struct list_head [noderef] __rcu *
>   .../i915_drm_client.c:92:9: sparse:    struct list_head *
>
> Signed-off-by: Tvrtko Ursulin <[email protected]>
> Fixes: 968853033d8a ("drm/i915: Implement fdinfo memory stats printing")
> Reported-by: kernel test robot <[email protected]>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Cc: Andi Shyti <[email protected]>
> Cc: Aravind Iddamsetty <[email protected]>

Reviewed-by: Jani Nikula <[email protected]>

> ---
>  drivers/gpu/drm/i915/i915_drm_client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drm_client.c 
> b/drivers/gpu/drm/i915/i915_drm_client.c
> index be9acfd9410e..fa6852713bee 100644
> --- a/drivers/gpu/drm/i915/i915_drm_client.c
> +++ b/drivers/gpu/drm/i915/i915_drm_client.c
> @@ -78,7 +78,7 @@ static void show_meminfo(struct drm_printer *p, struct 
> drm_file *file)
>       struct drm_i915_private *i915 = fpriv->i915;
>       struct drm_i915_gem_object *obj;
>       struct intel_memory_region *mr;
> -     struct list_head *pos;
> +     struct list_head __rcu *pos;
>       unsigned int id;
>  
>       /* Public objects. */

-- 
Jani Nikula, Intel

Reply via email to