2014-02-13 16:56 GMT-02:00 Damien Lespiau <[email protected]>: > Coverity points out that, if we end up in the 'failed' label, that's > precisely because we couldn't retrieve a fixed mode (ie fixed_mode is > NULL) and then "if (fixed_mode)" is always false. > > Remove that dead code. > > Signed-off-by: Damien Lespiau <[email protected]>
Reviewed-by: Paulo Zanoni <[email protected]> > --- > drivers/gpu/drm/i915/intel_lvds.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c > b/drivers/gpu/drm/i915/intel_lvds.c > index 6341a88..3984608 100644 > --- a/drivers/gpu/drm/i915/intel_lvds.c > +++ b/drivers/gpu/drm/i915/intel_lvds.c > @@ -1125,8 +1125,6 @@ failed: > DRM_DEBUG_KMS("No LVDS modes found, disabling.\n"); > drm_connector_cleanup(connector); > drm_encoder_cleanup(encoder); > - if (fixed_mode) > - drm_mode_destroy(dev, fixed_mode); > kfree(lvds_encoder); > kfree(lvds_connector); > return; > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
