On Wed, Jan 17, 2024 at 02:25:46PM +0200, Jani Nikula wrote: > Not sure if lid_state has ever been used, but at least not for a long > time. Remove it.
It was probably used when we had that disgusting lid notifier thing, but that got killed some years ago. > > Suggested-by: Ville Syrjälä <[email protected]> > Signed-off-by: Jani Nikula <[email protected]> Reviewed-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_opregion.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c > b/drivers/gpu/drm/i915/display/intel_opregion.c > index 3f5a20f9153e..f242bb320610 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.c > +++ b/drivers/gpu/drm/i915/display/intel_opregion.c > @@ -266,7 +266,6 @@ struct intel_opregion { > void *vbt_firmware; > const void *vbt; > u32 vbt_size; > - u32 *lid_state; > struct work_struct asle_work; > struct notifier_block acpi_notifier; > }; > @@ -958,7 +957,6 @@ int intel_opregion_setup(struct drm_i915_private > *dev_priv) > goto err_out; > } > opregion->header = base; > - opregion->lid_state = base + ACPI_CLID; > > drm_dbg(&dev_priv->drm, "ACPI OpRegion version %u.%u.%u\n", > opregion->header->over.major, > -- > 2.39.2 -- Ville Syrjälä Intel
