> -----Original Message-----
> From: Jani Nikula <[email protected]>
> Sent: Monday, February 26, 2024 11:17 PM
> To: Manna, Animesh <[email protected]>; intel-
> [email protected]
> Cc: [email protected]; Hogander, Jouni
> <[email protected]>; Murthy, Arun R <[email protected]>;
> Manna, Animesh <[email protected]>
> Subject: Re: [PATCH] drm/i915/panelreplay: Move out psr_init_dpcd() from
> init_connector()
>
> On Thu, 22 Feb 2024, Animesh Manna <[email protected]> wrote:
> > Move psr_init_dpcd() from init-connector to connector-detect function.
>
> Why?
>
> The commit message *must* *always* answer the question why, unless the
> reason is completely and utterly obvious (e.g. don't need to say why typos
> need to be fixed).
Agree, will add. Thanks for review.
Regards,
Animesh
>
> BR,
> Jani.
>
> > Signed-off-by: Animesh Manna <[email protected]>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
> > drivers/gpu/drm/i915/display/intel_psr.c | 3 ---
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 217196196e50..4553e1f5f1fc 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -5709,6 +5709,9 @@ intel_dp_detect(struct drm_connector
> *connector,
> > goto out;
> > }
> >
> > + if (!intel_dp_is_edp(intel_dp))
> > + intel_psr_init_dpcd(intel_dp);
> > +
> > intel_dp_detect_dsc_caps(intel_dp, intel_connector);
> >
> > intel_dp_configure_mst(intel_dp);
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 72cadad09db5..6927785fd6ff 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -2883,9 +2883,6 @@ void intel_psr_init(struct intel_dp *intel_dp)
> > if (!(HAS_PSR(dev_priv) || HAS_DP20(dev_priv)))
> > return;
> >
> > - if (!intel_dp_is_edp(intel_dp))
> > - intel_psr_init_dpcd(intel_dp);
> > -
> > /*
> > * HSW spec explicitly says PSR is tied to port A.
> > * BDW+ platforms have a instance of PSR registers per transcoder
> > but
>
> --
> Jani Nikula, Intel
