On Mon, Mar 18, 2024 at 02:00:25PM -0700, Radhakrishna Sripada wrote: > Disable clockgating for TDL SVHS fub. > > v2: Implement in general render/compute wa's(MattR) > > Bspec: 46045 > Cc: Matt Roper <[email protected]> > Signed-off-by: Radhakrishna Sripada <[email protected]>
Reviewed-by: Matt Roper <[email protected]> > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + > drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +++++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > index 50962cfd1353..1f778b77f4f8 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > @@ -1215,6 +1215,7 @@ > #define GEN12_DISABLE_EARLY_READ REG_BIT(14) > #define GEN12_ENABLE_LARGE_GRF_MODE REG_BIT(12) > #define GEN12_PUSH_CONST_DEREF_HOLD_DIS REG_BIT(8) > +#define XELPG_DISABLE_TDL_SVHS_GATING REG_BIT(1) > #define GEN12_DISABLE_DOP_GATING REG_BIT(0) > > #define RT_CTRL MCR_REG(0xe530) > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c > b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index b079cbbc1897..d2c63ecc490e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -2892,10 +2892,14 @@ general_render_compute_wa_init(struct intel_engine_cs > *engine, struct i915_wa_li > > if (IS_GFX_GT_IP_STEP(gt, IP_VER(12, 70), STEP_B0, STEP_FOREVER) || > IS_GFX_GT_IP_STEP(gt, IP_VER(12, 71), STEP_B0, STEP_FOREVER) || > - IS_GFX_GT_IP_RANGE(gt, IP_VER(12, 74), IP_VER(12, 74))) > + IS_GFX_GT_IP_RANGE(gt, IP_VER(12, 74), IP_VER(12, 74))) { > /* Wa_14017856879 */ > wa_mcr_masked_en(wal, GEN9_ROW_CHICKEN3, > MTL_DISABLE_FIX_FOR_EOT_FLUSH); > > + /* Wa_14020495402 */ > + wa_mcr_masked_en(wal, GEN8_ROW_CHICKEN2, > XELPG_DISABLE_TDL_SVHS_GATING); > + } > + > if (IS_GFX_GT_IP_STEP(gt, IP_VER(12, 70), STEP_A0, STEP_B0) || > IS_GFX_GT_IP_STEP(gt, IP_VER(12, 71), STEP_A0, STEP_B0)) > /* > -- > 2.34.1 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
