RE: [PATCH] drm/dp: correct struct member name in documentation

Thu, 11 Apr 2024 09:55:48 -0700 


> -----Original Message-----
> From: Vivi, Rodrigo <[email protected]>
> Sent: Wednesday, April 10, 2024 9:49 PM
> To: Golani, Mitulkumar Ajitkumar <[email protected]>;
> [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; 
> Nautiyal,
> Ankit K <[email protected]>; Nikula, Jani <[email protected]>;
> [email protected]
> Subject: Re: [PATCH] drm/dp: correct struct member name in documentation
> 
> On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote:
> > Correct struct member name to 'mode' instead of 'operation mode'
> > in 'drm_dp_as_sdp' structure description.
> >
> > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging")
> 
> Probably good to avoid this 'Fixes:' tag, and only use that for real code 
> bugs.

Thank you for inputs.. I understood and I will take the future note. Please 
suggest if required to update the change with new revision or we can take care 
while merge.. ?

> 
> Cc: Maarten Lankhorst <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> 
> drm-misc folks, ack to get this through drm-intel-next, where the original 
> patch
> is?
> 
> Thanks,
> Rodrigo
> 
> > Cc: Mitul Golani <[email protected]>
> > Cc: Ankit Nautiyal <[email protected]>
> > Cc: Jani Nikula <[email protected]>
> > Signed-off-by: Mitul Golani <[email protected]>
> 
> > ---
> >  include/drm/display/drm_dp_helper.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/display/drm_dp_helper.h
> > b/include/drm/display/drm_dp_helper.h
> > index baf9949ff96f..6799f57d635c 100644
> > --- a/include/drm/display/drm_dp_helper.h
> > +++ b/include/drm/display/drm_dp_helper.h
> > @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp {
> >   * @target_rr: Target Refresh
> >   * @duration_incr_ms: Successive frame duration increase
> >   * @duration_decr_ms: Successive frame duration decrease
> > - * @operation_mode: Adaptive Sync Operation Mode
> > + * @mode: Adaptive Sync Operation Mode
> >   */
> >  struct drm_dp_as_sdp {
> >     unsigned char sdp_type;
> > --
> > 2.25.1
> >






















					Reply via email to