> -----Original Message----- > From: Kandpal, Suraj <[email protected]> > Sent: Thursday, April 11, 2024 11:39 AM > To: [email protected] > Cc: Borah, Chaitanya Kumar <[email protected]>; Shankar, > Uma <[email protected]>; Nautiyal, Ankit K > <[email protected]>; Murthy, Arun R <[email protected]>; > Nikula, Jani <[email protected]>; Kumar, Naveen1 > <[email protected]>; Kandpal, Suraj <[email protected]> > Subject: [PATCH 1/6] drm/i915/dp: Make has_gamut_metadata_dip() non static > > Make has_gamut_metadata_dip() non static so it can also be used to at other > places eg in intel_dp_aux_backlight. Can you specify as to why this has to be referenced from backlight?
Upon adding the above justification Reviewed-by: Arun R Murthy <[email protected]> Thanks and Regards, Arun R Murthy ------------------- > > Signed-off-by: Suraj Kandpal <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- > drivers/gpu/drm/i915/display/intel_dp.h | 1 + > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index 163da48bc406..8b105efd4de9 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6365,8 +6365,8 @@ bool intel_dp_is_port_edp(struct drm_i915_private > *i915, enum port port) > return _intel_dp_is_port_edp(i915, devdata, port); } > > -static bool > -has_gamut_metadata_dip(struct intel_encoder *encoder) > +bool > +intel_dp_has_gamut_metadata_dip(struct intel_encoder *encoder) > { > struct drm_i915_private *i915 = to_i915(encoder->base.dev); > enum port port = encoder->port; > @@ -6413,7 +6413,7 @@ intel_dp_add_properties(struct intel_dp *intel_dp, > struct drm_connector *connect > intel_attach_dp_colorspace_property(connector); > } > > - if (has_gamut_metadata_dip(&dp_to_dig_port(intel_dp)->base)) > + if (intel_dp_has_gamut_metadata_dip(&dp_to_dig_port(intel_dp)- > >base)) > > drm_connector_attach_hdr_output_metadata_property(connector); > > if (HAS_VRR(dev_priv)) > diff --git a/drivers/gpu/drm/i915/display/intel_dp.h > b/drivers/gpu/drm/i915/display/intel_dp.h > index 106ecfde36d9..aad2223df2a3 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.h > +++ b/drivers/gpu/drm/i915/display/intel_dp.h > @@ -196,5 +196,6 @@ intel_dp_compute_config_link_bpp_limits(struct > intel_dp *intel_dp, > struct link_config_limits *limits); > > void intel_dp_get_dsc_sink_cap(u8 dpcd_rev, struct intel_connector > *connector); > +bool intel_dp_has_gamut_metadata_dip(struct intel_encoder *encoder); > > #endif /* __INTEL_DP_H__ */ > -- > 2.43.2
