On Mon, 22 Apr 2024, Ville Syrjala <[email protected]> wrote:
> From: Ville Syrjälä <[email protected]>
>
> We don't use the result of the VLV_PCS01_DW8 read at all,
> so don't read.
Mmmh, maybe the intention was to be a rmw? Since this appears to have
worked, okay.
This part becomes a bit pointless:
else
val &= ~(1<<21);
but it was already there and you seem to clean this up in patch 13 so
*shrug*.
Reviewed-by: Jani Nikula <[email protected]>
>
> Signed-off-by: Ville Syrjälä <[email protected]>
> ---
> drivers/gpu/drm/i915/display/intel_dpio_phy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> index c72b76b61dff..6cbee88e608f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> @@ -1134,7 +1134,6 @@ void vlv_phy_pre_encoder_enable(struct intel_encoder
> *encoder,
> vlv_dpio_get(dev_priv);
>
> /* Enable clock channels for this port */
> - val = vlv_dpio_read(dev_priv, phy, VLV_PCS01_DW8(port));
> val = 0;
> if (pipe)
> val |= (1<<21);
--
Jani Nikula, Intel
