On Tue, Apr 30, 2024 at 01:09:56PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the EDP_PSR_CTL register macro.
> 
> Signed-off-by: Jani Nikula <[email protected]>

Reviewed-by: Rodrigo Vivi <[email protected]>

> ---
>  drivers/gpu/drm/i915/display/intel_psr.c      | 2 +-
>  drivers/gpu/drm/i915/display/intel_psr_regs.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c 
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 1cbd8c6714b1..57414a1375b1 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -269,7 +269,7 @@ static i915_reg_t psr_ctl_reg(struct drm_i915_private 
> *dev_priv,
>                             enum transcoder cpu_transcoder)
>  {
>       if (DISPLAY_VER(dev_priv) >= 8)
> -             return EDP_PSR_CTL(cpu_transcoder);
> +             return EDP_PSR_CTL(dev_priv, cpu_transcoder);
>       else
>               return HSW_SRD_CTL;
>  }
> diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h 
> b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> index 0e0c71ea9fe3..d815f08aac2c 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> @@ -23,7 +23,7 @@
>  #define HSW_SRD_CTL                          _MMIO(0x64800)
>  #define _SRD_CTL_A                           0x60800
>  #define _SRD_CTL_EDP                         0x6f800
> -#define EDP_PSR_CTL(tran)                    _MMIO_TRANS2(dev_priv, tran, 
> _SRD_CTL_A)
> +#define EDP_PSR_CTL(dev_priv, tran)                  _MMIO_TRANS2(dev_priv, 
> tran, _SRD_CTL_A)
>  #define   EDP_PSR_ENABLE                     REG_BIT(31)
>  #define   BDW_PSR_SINGLE_FRAME                       REG_BIT(30)
>  #define   EDP_PSR_RESTORE_PSR_ACTIVE_CTX_MASK        REG_BIT(29) /* SW can't 
> modify */
> -- 
> 2.39.2
> 

Reply via email to