On Mon, Jul 01, 2024 at 02:27:56PM GMT, Matthew Auld wrote:
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h index 2feedddf1e40..a4256144dff7 100644 --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h @@ -15,6 +15,9 @@ #include "i915_utils.h" #include "intel_runtime_pm.h" #include "xe_device_types.h" +#include "xe_wa.h" + +#include <generated/xe_wa_oob.h>
I think building xe.ko with this include in a header will be racy: any file that has this include needs to declare the dependency in the Makefile. I tried a few alternatives to convince the build system to always execute the generate-rules before anything else, but it failed CI: https://patchwork.freedesktop.org/series/132331/ I think we will need that before allowing XE_WA() to show up in header files. Lucas De Marchi
