On Mon, 29 Jul 2024, "Kandpal, Suraj" <[email protected]> wrote: >> -----Original Message----- >> From: Jani Nikula <[email protected]> >> Sent: Monday, July 29, 2024 3:26 PM >> To: Kandpal, Suraj <[email protected]>; intel- >> [email protected] >> Cc: Nautiyal, Ankit K <[email protected]>; Kandpal, Suraj >> <[email protected]> >> Subject: Re: [PATCH] drm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro >> >> On Mon, 29 Jul 2024, Suraj Kandpal <[email protected]> wrote: >> > Fix HDCP2_STREAM_STATUS macro, it called pipe instead of port never >> > threw a compile error as no one used it. >> >> Fixes: ? >> > > Anyway to find it, > Did a git blame but since one of your patches separated intel_hdcp_regs.h > from i915_regs.h > All I can see is your commit which I don't think is the correct commit to add.
Please just dig deeper. git blaming through refactoring is an essential skill. BR, Jani. > > Regards, > Suraj Kandpal > >> > >> > Signed-off-by: Suraj Kandpal <[email protected]> >> > --- >> > drivers/gpu/drm/i915/display/intel_hdcp_regs.h | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > index a568a457e532..f590d7f48ba7 100644 >> > --- a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > @@ -251,7 +251,7 @@ >> > #define HDCP2_STREAM_STATUS(dev_priv, trans, port) \ >> > (TRANS_HDCP(dev_priv) ? \ >> > >> TRANS_HDCP2_STREAM_STATUS(trans) : \ >> > - PIPE_HDCP2_STREAM_STATUS(pipe)) >> > + PIPE_HDCP2_STREAM_STATUS(port)) >> > >> > #define _PORTA_HDCP2_AUTH_STREAM 0x66F00 >> > #define _PORTB_HDCP2_AUTH_STREAM 0x66F04 >> >> -- >> Jani Nikula, Intel -- Jani Nikula, Intel
