== Series Details ==
Series: Display Global Histogram (rev3)
URL : https://patchwork.freedesktop.org/series/135793/
State : warning
== Summary ==
Error: dim checkpatch failed
0a61cdbcaca7 drm/i915/histogram: Add support for histogram
-:44: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#44:
new file mode 100644
-:239: WARNING:BRACES: braces {} are not necessary for single statement blocks
#239: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:191:
+ if (!histogram) {
+ return -ENOMEM;
+ }
-:255: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for
'drivers/gpu/drm/i915/display/intel_histogram.h', please use '/*' instead
#255: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:1:
+// SPDX-License-Identifier: MIT
-:255: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#255: FILE: drivers/gpu/drm/i915/display/intel_histogram.h:1:
+// SPDX-License-Identifier: MIT
-:296: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for
'drivers/gpu/drm/i915/display/intel_histogram_reg.h', please use '/*' instead
#296: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:1:
+// SPDX-License-Identifier: MIT
-:296: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier
tag in line 1
#296: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:1:
+// SPDX-License-Identifier: MIT
-:315: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#315: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:20:
+#define DPST_CTL_EN_MULTIPLICATIVE
REG_FIELD_PREP(DPST_CTL_ENHANCEMENT_MODE_MASK, 2)
-:322: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#322: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:27:
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_2INT_8FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 1)
-:323: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#323: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:28:
+#define DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC
REG_FIELD_PREP(DPST_CTL_IE_TABLE_VALUE_FORMAT, 0)
-:329: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#329: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:34:
+#define DPST_GUARD(pipe) _MMIO_PIPE(pipe,
_DPST_GUARD_A, _DPST_GUARD_B)
-:333: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#333: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:38:
+#define DPST_GUARD_INTERRUPT_DELAY(val)
REG_FIELD_PREP(DPST_GUARD_INTERRUPT_DELAY_MASK, val)
-:335: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#335: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:40:
+#define DPST_GUARD_THRESHOLD_GB(val)
REG_FIELD_PREP(DPST_GUARD_THRESHOLD_GB_MASK, val)
total: 0 errors, 12 warnings, 0 checks, 304 lines checked
957cbd364c1b drm/xe: Add histogram support to Xe builds
0cf4916be261 drm/i915/histogram: histogram interrupt handling
-:6: WARNING:TYPO_SPELLING: 'trigerred' may be misspelled - perhaps 'triggered'?
#6:
Upon enabling histogram an interrupt is trigerred after the generation
^^^^^^^^^
-:108: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be
better as static const
#108: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:75:
+ char *histogram_event[] = {"HISTOGRAM=1", NULL};
total: 0 errors, 2 warnings, 0 checks, 184 lines checked
a8d112d8eecd drm/i915/histogram: Add crtc properties for global histogram
-:323: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#323: FILE: drivers/gpu/drm/i915/display/intel_display.c:7572:
+ (u32
*)new_crtc_state->histogram.global_iet->data);
-:367: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#367: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:86:
+ drm_property_replace_global_blob(display->drm,
+ &intel_crtc->config->histogram.histogram,
total: 0 errors, 1 warnings, 1 checks, 320 lines checked
03f685e020db drm/i915/histogram: histogram delay counter doesnt reset
-:4: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'?
#4:
Subject: [PATCH] drm/i915/histogram: histogram delay counter doesnt reset
^^^^^^
-:35: WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#35: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:104:
+ /* Write the value read from DPST_CTL to DPST_CTL.Interrupt
Delay Counter(bit 23:16) */
-:37: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#37: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:106:
+ intel_de_write(display, DPST_CTL(intel_crtc->pipe),
intel_de_read(display,
+ DPST_CTL(intel_crtc->pipe)) | DPST_CTL_RESTORE);
-:48: WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#48: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:261:
+ /* Write the value read from DPST_CTL to DPST_CTL.Interrupt
Delay Counter(bit 23:16) */
-:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#50: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:263:
+ intel_de_write(display, DPST_CTL(intel_crtc->pipe),
intel_de_read(display,
+ DPST_CTL(intel_crtc->pipe)) | DPST_CTL_RESTORE);
total: 0 errors, 3 warnings, 2 checks, 42 lines checked
6e900dc688e5 drm/i915/histogram: Histogram changes for Display 20+
-:22: WARNING:INLINE: plain inline is preferred over __inline__
#22: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:32:
+static __inline__ void set_bin_index_0(struct intel_display *display, enum
pipe pipe)
-:33: WARNING:INLINE: plain inline is preferred over __inline__
#33: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:43:
+static __inline__ void write_iet(struct intel_display *display, enum pipe pipe,
-:34: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#34: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:44:
+static __inline__ void write_iet(struct intel_display *display, enum pipe pipe,
+ u32 *data)
-:56: WARNING:INLINE: plain inline is preferred over __inline__
#56: FILE: drivers/gpu/drm/i915/display/intel_histogram.c:66:
+static __inline__ void set_histogram_index_0(struct intel_display *display,
enum pipe pipe)
-:194: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#194: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:52:
+#define DPST_HIST_INDEX(pipe) _MMIO_PIPE(pipe,
_DPST_HIST_INDEX_A, _DPST_HIST_INDEX_B)
-:196: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#196: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:54:
+#define DPST_HIST_BIN_INDEX(val)
REG_FIELD_PREP(DPST_HIST_BIN_INDEX_MASK, val)
-:200: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#200: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:58:
+#define DPST_HIST_BIN(pipe) _MMIO_PIPE(pipe,
_DPST_HIST_BIN_A, _DPST_HIST_BIN_B)
-:206: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#206: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:64:
+#define DPST_IE_BIN(pipe) _MMIO_PIPE(pipe,
_DPST_IE_BIN_A, _DPST_IE_BIN_B)
-:212: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#212: FILE: drivers/gpu/drm/i915/display/intel_histogram_reg.h:70:
+#define DPST_IE_INDEX(pipe) _MMIO_PIPE(pipe,
_DPST_IE_INDEX_A, _DPST_IE_INDEX_B)
total: 0 errors, 8 warnings, 1 checks, 189 lines checked
