On Fri, 27 Sep 2024, Animesh Manna <[email protected]> wrote: > @@ -246,7 +251,8 @@ void intel_vrr_compute_config_late(struct > intel_crtc_state *crtc_state) > struct intel_display *display = to_intel_display(crtc_state); > struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; > > - if (!crtc_state->vrr.flipline) > + //if (!crtc_state->vrr.flipline) > + if (!intel_vrr_possible(crtc_state)) > return; > > if (DISPLAY_VER(display) >= 13) { > @@ -286,7 +292,8 @@ void intel_vrr_set_transcoder_timings(const struct > intel_crtc_state *crtc_state) > intel_de_rmw(display, CHICKEN_TRANS(cpu_transcoder), > 0, PIPE_VBLANK_WITH_DELAY); > > - if (!crtc_state->vrr.flipline) { > + //if (!crtc_state->vrr.flipline) { > + if (!intel_vrr_possible(crtc_state)) { > intel_de_write(display, > TRANS_VRR_CTL(display, cpu_transcoder), 0); > return;
What's the point of even sending this? What am I supposed to do with this? The series is at v12. We should aim at converging to merge at maybe v3 or v5 or so, at the latest. There are legitimate cases where v1 or v2 are RFC-like, figuring out the direction etc., but the goal for every single version after that should be that it's the last. BR, Jani. -- Jani Nikula, Intel
