RE: [PATCH 1/6] drm/i915/wm: Initialize max_latency variable to appropriate value

Wed, 04 Dec 2024 17:36:06 -0800 


> -----Original Message-----
> From: Kandpal, Suraj <[email protected]>
> Sent: 03 December 2024 14:17
> To: [email protected]; [email protected]
> Cc: Golani, Mitulkumar Ajitkumar <[email protected]>;
> Kandpal, Suraj <[email protected]>
> Subject: [PATCH 1/6] drm/i915/wm: Initialize max_latency variable to
> appropriate value
> 
> Initialize max_latency variable to LNL_PKG_C_LATENCY_MASK which helps to
> eliminate the else block and make the whole code a lot cleaner.
> 
> --v2
> -Seprate patch to club variables together [Mitul]
> 
> Signed-off-by: Suraj Kandpal <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/skl_watermark.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> b/drivers/gpu/drm/i915/display/skl_watermark.c
> index 1a4c1fa24820..c40e0173a5bd 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -2857,7 +2857,7 @@ static int skl_wm_add_affected_planes(struct
> intel_atomic_state *state,  static void  skl_program_dpkgc_latency(struct
> drm_i915_private *i915, bool enable_dpkgc)  {
> -     u32 max_latency = 0;
> +     u32 max_latency = LNL_PKG_C_LATENCY_MASK;
>       u32 clear = 0, val = 0;
>       u32 added_wake_time = 0;
> 
> @@ -2870,9 +2870,6 @@ skl_program_dpkgc_latency(struct
> drm_i915_private *i915, bool enable_dpkgc)
>                       max_latency = LNL_PKG_C_LATENCY_MASK;
>               added_wake_time = DSB_EXE_TIME +
>                       i915->display.sagv.block_time_us;
> -     } else {
> -             max_latency = LNL_PKG_C_LATENCY_MASK;
> -             added_wake_time = 0;

Reviewed-by: Mitul Golani <[email protected]>
>       }
> 
>       clear |= LNL_ADDED_WAKE_TIME_MASK |
> LNL_PKG_C_LATENCY_MASK;
> --
> 2.34.1
























					Reply via email to