Thanks for review! > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > index 94198bc04939..6c960416f776 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > @@ -793,7 +793,7 @@ int intel_dp_tunnel_mgr_init(struct intel_display > > *display) > > drm_connector_list_iter_end(&connector_list_iter); > > > > tunnel_mgr = drm_dp_tunnel_mgr_create(display->drm, dp_connectors); > > - if (IS_ERR(tunnel_mgr)) > > + if (IS_ERR_OR_NULL(tunnel_mgr)) > > nicely spotted, but the fix is wrong. drm_dp_tunnel_mgr_create() > returns NULL, not an error, so that you can just check: > > if (!tunnel_mgr) > ... I thought about this too, but then that would ignore the return from drm_dp_tunnel_mgr_create() stub in drm_dp_tunnel.h (the one returning ERR_PTR(-ENOTSUPP) if CONFIG_DRM_DISPLAY_DP_TUNNEL is not enabled).
Krzysztof Karas >
