On Tue, 17 Dec 2024, Ankit Nautiyal <[email protected]> wrote: > Support for FEC is already checked by intel_dp_supports_dsc() in > intel_dp_dsc_compute_config() which gets called before > intel_dp_fec_compute_config(). > > Therefore the check can be dropped from the helper > intel_dp_fec_compute_config(). > > v2: Changed commit message for clarity. (Suraj) > > Signed-off-by: Ankit Nautiyal <[email protected]> > Reviewed-by: Suraj Kandpal <[email protected]>
Reviewed-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index 674297ac6315..9a039cbdfcc9 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2351,7 +2351,6 @@ static int intel_edp_dsc_compute_pipe_bpp(struct > intel_dp *intel_dp, > } > > static void intel_dp_fec_compute_config(struct intel_dp *intel_dp, > - const struct intel_connector *connector, > struct intel_crtc_state *crtc_state) > { > if (crtc_state->fec_enable) > @@ -2365,9 +2364,6 @@ static void intel_dp_fec_compute_config(struct intel_dp > *intel_dp, > if (intel_dp_is_edp(intel_dp)) > return; > > - if (!intel_dp_supports_fec(intel_dp, connector, crtc_state)) > - return; > - > if (intel_dp_is_uhbr(crtc_state)) > return; > > @@ -2389,7 +2385,7 @@ int intel_dp_dsc_compute_config(struct intel_dp > *intel_dp, > int num_joined_pipes = intel_crtc_num_joined_pipes(pipe_config); > int ret; > > - intel_dp_fec_compute_config(intel_dp, connector, pipe_config); > + intel_dp_fec_compute_config(intel_dp, pipe_config); > > if (!intel_dp_dsc_supports_format(connector, > pipe_config->output_format)) > return -EINVAL; -- Jani Nikula, Intel
