Hi Jani, > -----Original Message----- > From: Jani Nikula <[email protected]> > Sent: Tuesday, January 7, 2025 6:22 PM > To: Gote, Nitin R <[email protected]>; [email protected] > Cc: Shyti, Andi <[email protected]>; Gote, Nitin R <[email protected]> > Subject: Re: [PATCH v1 7/8] drm/i915/display: fix typos in i915/display files > > On Mon, 06 Jan 2025, Nitin Gote <[email protected]> wrote: > > @@ -8440,7 +8440,7 @@ intel_mode_valid_max_plane_size(struct > > drm_i915_private *dev_priv, > > > > /* > > * Most people will probably want a fullscreen > > - * plane so let's not advertize modes that are > > + * plane so let's not advertise modes that are > > * too big for that. > > */ > > if (DISPLAY_VER(dev_priv) >= 30) { > > I appreciate the typo fixes, but there's an explicit policy that certain > things are not > typos and should not be fixed. This includes British vs. American spelling. > > Can you not tell codespell that?
Codespell has --builtin option for 'en-GB_to_en-US' for corrections from en-GB to en-US', which we can't use as it corrects en-GB spelling to en-US spelling. And there is no other option to include both British vs American spelling. I will correct this in the next version. > > > @@ -2552,7 +2552,7 @@ intel_dp_compute_config_limits(struct intel_dp > *intel_dp, > > * seem to suggest we should do otherwise. > > * > > * Use the maximum clock and number of lanes the eDP panel > > - * advertizes being capable of in case the initial fast > > + * advertises being capable of in case the initial fast > > * optimal params failed us. The panels are generally > > * designed to support only a single clock and lane > > * configuration, and typically on older panels these > > Ditto. I will update it. > > > @@ -442,8 +444,10 @@ static int intel_overlay_off(struct intel_overlay > *overlay) > > return i915_active_wait(&overlay->last_flip); > > } > > > > -/* recover from an interruption due to a signal > > - * We have to be careful not to repeat work forever an make forward > > progess. */ > > +/* > > + * recover from an interruption due to a signal > > + * We have to be careful not to repeat work forever an make forward > > progress. > > + */ > > If you're changing the comment format while at it, might as well capitalize > the > first sentence and add a period. > Thanks for pointing out. I will fix it in the next version. - Nitin > > BR, > Jani. > > > -- > Jani Nikula, Intel
