On Thu, 16 Jan 2025, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > Pull the "do we actually need a LRR update?" checks into a small > helper for clarity. > > Cc: Paz Zcharya <[email protected]> > Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index fa398d7d1baa..9b42d980ed7e 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -6081,6 +6081,13 @@ static int intel_modeset_checks(struct > intel_atomic_state *state) > return 0; > } > > +static bool lrr_params_changed(const struct drm_display_mode > *old_adjusted_mode, > + const struct drm_display_mode *new_adjusted_mode) > +{ > + return old_adjusted_mode->crtc_vblank_end != > new_adjusted_mode->crtc_vblank_end || > + old_adjusted_mode->crtc_vtotal != > new_adjusted_mode->crtc_vtotal; > +} > + > static void intel_crtc_check_fastset(const struct intel_crtc_state > *old_crtc_state, > struct intel_crtc_state *new_crtc_state) > { > @@ -6101,8 +6108,8 @@ static void intel_crtc_check_fastset(const struct > intel_crtc_state *old_crtc_sta > &new_crtc_state->dp_m_n)) > new_crtc_state->update_m_n = false; > > - if ((old_crtc_state->hw.adjusted_mode.crtc_vtotal == > new_crtc_state->hw.adjusted_mode.crtc_vtotal && > - old_crtc_state->hw.adjusted_mode.crtc_vblank_end == > new_crtc_state->hw.adjusted_mode.crtc_vblank_end)) > + if (!lrr_params_changed(&old_crtc_state->hw.adjusted_mode, > + &new_crtc_state->hw.adjusted_mode)) > new_crtc_state->update_lrr = false; > > if (intel_crtc_needs_modeset(new_crtc_state)) -- Jani Nikula, Intel
