On Tue, 11 Mar 2025, Gustavo Sousa <[email protected]> wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c > b/drivers/gpu/drm/i915/display/intel_bw.c > index > 048be287224774110d94fe2944daa580d8dc20a6..6f805af32926d3608929655de97699747d7a5798 > 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -39,14 +39,15 @@ struct intel_qgv_info { > u8 deinterleave; > }; > > -static int dg1_mchbar_read_qgv_point_info(struct drm_i915_private *dev_priv, > +static int dg1_mchbar_read_qgv_point_info(struct intel_display *display, > struct intel_qgv_point *sp, > int point) > { > + struct drm_i915_private *i915 = to_i915(display->drm);
This is reviewed already, and I'm not requesting changes, but for future reference, I tend to keep the dev_priv name where it's already being used. We don't really benefit from dev_priv -> i915 conversions anymore in display, they'll all need to be removed eventually, but this causes extra churn where none is required. > u32 dclk_ratio, dclk_reference; > u32 val; > > - val = intel_uncore_read(&dev_priv->uncore, > SA_PERF_STATUS_0_0_0_MCHBAR_PC); > + val = intel_uncore_read(&i915->uncore, SA_PERF_STATUS_0_0_0_MCHBAR_PC); Like above. BR, Jani. -- Jani Nikula, Intel
