> -----Original Message-----
> From: Kandpal, Suraj <suraj.kand...@intel.com>
> Sent: Thursday, 15 May 2025 10.18
> To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Cc: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>; Murthy, Arun R
> <arun.r.mur...@intel.com>; Nikula, Jani
> <jani.nik...@intel.com>; Kahola, Mika <mika.kah...@intel.com>; Kandpal, Suraj
> <suraj.kand...@intel.com>
> Subject: [PATCH 10/14] drm/i915/dpll: Rename intel_unreference_dpll_crtc
>
> Rename intel_unreference_dpll_crtc to intel_dpll_crtc_put in an effort to
> keep names of exported functions start with the
> filename.
>
> --v2
> -Make the new name more sensible [Jani]
>
Reviewed-by: Mika Kahola <mika.kah...@intel.com>
> Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 10 +++++-----
> drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 6 +++---
> drivers/gpu/drm/i915/display/intel_modeset_setup.c | 6 +++---
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 2b592423e1d1..1265bc4b4307 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -451,7 +451,7 @@ intel_reference_dpll(struct intel_atomic_state *state, }
>
> /**
> - * intel_unreference_dpll_crtc - Drop a DPLL reference for a CRTC
> + * intel_dpll_crtc_put - Drop a DPLL reference for a CRTC
> * @crtc: CRTC on which behalf the reference is dropped
> * @pll: DPLL for which the reference is dropped
> * @dpll_state: the DPLL atomic state in which the reference is tracked @@
> -459,9 +459,9 @@ intel_reference_dpll(struct
> intel_atomic_state *state,
> * Drop a reference for @pll tracking the end of use of it by @crtc.
> */
> void
> -intel_unreference_dpll_crtc(const struct intel_crtc *crtc,
> - const struct intel_dpll *pll,
> - struct intel_dpll_state *dpll_state)
> +intel_dpll_crtc_put(const struct intel_crtc *crtc,
> + const struct intel_dpll *pll,
> + struct intel_dpll_state *dpll_state)
> {
> struct intel_display *display = to_intel_display(crtc);
>
> @@ -481,7 +481,7 @@ static void intel_unreference_dpll(struct
> intel_atomic_state *state,
>
> dpll_state = intel_atomic_get_dpll_state(&state->base);
>
> - intel_unreference_dpll_crtc(crtc, pll, &dpll_state[pll->index]);
> + intel_dpll_crtc_put(crtc, pll, &dpll_state[pll->index]);
> }
>
> static void intel_put_dpll(struct intel_atomic_state *state, diff --git
> a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> index 88a81c850cf0..f8ba7b52a7ad 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> @@ -404,9 +404,9 @@ int intel_reserve_dplls(struct intel_atomic_state *state,
> struct intel_encoder *encoder);
> void intel_release_dplls(struct intel_atomic_state *state,
> struct intel_crtc *crtc);
> -void intel_unreference_dpll_crtc(const struct intel_crtc *crtc,
> - const struct intel_dpll *pll,
> - struct intel_dpll_state *shared_dpll_state);
> +void intel_dpll_crtc_put(const struct intel_crtc *crtc,
> + const struct intel_dpll *pll,
> + struct intel_dpll_state *shared_dpll_state);
> void icl_set_active_port_dpll(struct intel_crtc_state *crtc_state,
> enum icl_port_dpll_id port_dpll_id); void
> intel_update_active_dpll(struct intel_atomic_state *state,
> diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> index ed4f305e0d3e..22c5302e3798 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> @@ -93,9 +93,9 @@ static void intel_crtc_disable_noatomic_begin(struct
> intel_crtc *crtc,
> crtc->base.enabled = false;
>
> if (crtc_state->intel_dpll)
> - intel_unreference_dpll_crtc(crtc,
> - crtc_state->intel_dpll,
> - &crtc_state->intel_dpll->state);
> + intel_dpll_crtc_put(crtc,
> + crtc_state->intel_dpll,
> + &crtc_state->intel_dpll->state);
> }
>
> static void set_encoder_for_connector(struct intel_connector *connector,
> --
> 2.34.1
