Hi Joonas, On Thu, May 22, 2025 at 09:25:04AM +0300, Joonas Lahtinen wrote: > (+ Tvrkto) > > Quoting Ville Syrjala (2025-04-11 17:43:12) > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > > The intel-media-driver is currently broken on DG1 because > > it uses EXEC_CAPTURE with recovarable contexts. Relax the > > check to allow that. > > > > I've also submitted a fix for the intel-media-driver: > > https://github.com/intel/media-driver/pull/1920 > > > > Cc: sta...@vger.kernel.org > > Cc: Matthew Auld <matthew.a...@intel.com> > > Cc: Thomas Hellström <thomas.hellst...@linux.intel.com> > > Testcase: igt/gem_exec_capture/capture-invisible > > Fixes: 71b1669ea9bd ("drm/i915/uapi: tweak error capture on recoverable > > contexts") > > Reviewed-by: Andi Shyti <andi.sh...@linux.intel.com> > > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > > --- > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > index ca7e9216934a..ea9d5063ce78 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > @@ -2013,7 +2013,7 @@ static int eb_capture_stage(struct i915_execbuffer > > *eb) > > continue; > > > > if (i915_gem_context_is_recoverable(eb->gem_context) && > > - (IS_DGFX(eb->i915) || GRAPHICS_VER_FULL(eb->i915) > > > IP_VER(12, 0))) > > + GRAPHICS_VER_FULL(eb->i915) > IP_VER(12, 10)) > > The IS_DGFX check was there because the error capture is expected to be > broken on anything with VRAM. > > If we have already submitted an userspace fix to remove that flag, that > would be the right way to go.
Oh! We need to add a comment there, though, because in the future I expect someone else might decide to send the same patch. Andi
