On Thu, 29 May 2025 11:20:36 -0400 Jeff Layton wrote: > Sorry for the reposting, but this makes things easier with automated CI. > > This posting just drops the pr_warn() calls from the new functions. We > were still seeing some warnings during (expected) times that debugfs > file creation would fail. debugfs already throws warnings when these > things fail unexpectedly, so these warnings are unwanted when dentry > creation fails before debugfs is up.
Hm, so FWIW we hit a lockdep issue now raw: https://netdev-3.bots.linux.dev/vmksft-tcp-ao-dbg/results/142540/4-connect-deny-ipv6/stderr decoded: https://netdev-3.bots.linux.dev/vmksft-tcp-ao-dbg/results/142540/vm-crash-thr0-10 I suspect this may just be "merge window fun", since we forwarded our trees to Linus's since your v11? [ 14.281410][ C0] inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. [ 14.281692][ C0] swapper/0/0 [HC0[0]:SC1[1]:HE1:SE0] takes: [ 14.281974][ C0] ffffffff9e1c5af8 (pin_fs_lock){+.?.}-{3:3}, at: simple_pin_fs+0x24/0x150 [ 14.282373][ C0] {SOFTIRQ-ON-W} state was registered at: [ 14.282614][ C0] __lock_acquire+0x20b/0x7e0 [ 14.282849][ C0] lock_acquire.part.0+0xb6/0x240 [ 14.283072][ C0] _raw_spin_lock+0x33/0x40 [ 14.283298][ C0] simple_pin_fs+0x24/0x150 [ 14.283524][ C0] start_creating.part.0+0x52/0x310 [ 14.283752][ C0] debugfs_create_dir+0x6a/0x540 [ 14.283977][ C0] component_debug_init+0x17/0x30 [ 14.284206][ C0] do_one_initcall+0x8f/0x1e0 [ 14.284451][ C0] do_initcalls+0x176/0x280 [ 14.284679][ C0] kernel_init_freeable+0x22d/0x300 [ 14.284907][ C0] kernel_init+0x20/0x200 [ 14.285131][ C0] ret_from_fork+0x240/0x320 [ 14.285359][ C0] ret_from_fork_asm+0x1a/0x30 [ 14.285580][ C0] irq event stamp: 410868 [ 14.285750][ C0] hardirqs last enabled at (410868): [<ffffffff9cfc332d>] _raw_spin_unlock_irqrestore+0x5d/0x80 [ 14.286200][ C0] hardirqs last disabled at (410867): [<ffffffff9cfc300b>] _raw_spin_lock_irqsave+0x5b/0x60 [ 14.286653][ C0] softirqs last enabled at (409604): [<ffffffff9a6877a8>] handle_softirqs+0x358/0x620 [ 14.287061][ C0] softirqs last disabled at (409635): [<ffffffff9a687bfa>] __irq_exit_rcu+0xfa/0x160
