Hi Jeff, > I got some warnings from the i915 CI with the ref_tracker debugfs > patches applied, that indicated that these ref_tracker_dir_init() calls > were being called more than once. If references were held on these > objects between the initializations, then that could lead to leaked ref > tracking objects. > > Since these objects are zalloc'ed, ensure that they are only initialized > once by testing whether the first byte of the name field is 0.
Are you referring to these warnings? <3> [314.043410] debugfs: File 'intel_wakeref@ffff88815111a308' in directory 'ref_tracker' already present! <4> [314.043427] ref_tracker: ref_tracker: unable to create debugfs file for intel_wakeref@ffff88815111a308: -EEXIST I think those might be caused by introduction of: "ref_tracker: automatically register a file in debugfs for a ref_tracker_dir". Current version of "ref_tracker: add a static classname string to each ref_tracker_dir" further in this series should prevent multiple calls to "ref_tracker_dir_init()", so this patch could be dropped I think. If my reasoning is wrong however, then please add a note to the commit message which explains why this is needed in more detail or/and move this patch right before it is necessary. Otherwise it looks like a vague workaround. Best Regards, Krzysztof
