> -----Original Message-----
> From: Kandpal, Suraj <suraj.kand...@intel.com>
> Sent: Monday, April 14, 2025 9:46 AM
> To: nouv...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; intel-
> x...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Cc: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>; Murthy, Arun R
> <arun.r.mur...@intel.com>; Kandpal, Suraj <suraj.kand...@intel.com>
> Subject: [PATCH 05/13] drm/dp: Change current_level argument type to u32
>
> Change the current_level argument type to u32 from u16 since it can now carry
> the value which it gets from DP_EDP_PANEL_TARGET_LUMINANCE_VALUE.
>
> Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
> ---
Looks good to me!
Reviewed-by: Arun R Murthy <arun.r.mur...@intel.com>
Thanks and Regards,
Arun R Murthy
--------------------
> drivers/gpu/drm/display/drm_dp_helper.c | 4 ++--
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_backlight.c | 2 +-
> include/drm/display/drm_dp_helper.h | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
> b/drivers/gpu/drm/display/drm_dp_helper.c
> index 1322bdfb6c8b..c58973d8c5f0 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -4247,7 +4247,7 @@ int
> drm_edp_backlight_init(struct drm_dp_aux *aux, struct
> drm_edp_backlight_info *bl,
> struct drm_luminance_range_info *lr,
> u16 driver_pwm_freq_hz, const u8
> edp_dpcd[EDP_DISPLAY_CTL_CAP_SIZE],
> - u16 *current_level, u8 *current_mode, bool
> need_luminance)
> + u32 *current_level, u8 *current_mode, bool
> need_luminance)
> {
> int ret;
>
> @@ -4355,7 +4355,7 @@ int drm_panel_dp_aux_backlight(struct drm_panel
> *panel, struct drm_dp_aux *aux) {
> struct dp_aux_backlight *bl;
> struct backlight_properties props = { 0 };
> - u16 current_level;
> + u32 current_level;
> u8 current_mode;
> u8 edp_dpcd[EDP_DISPLAY_CTL_CAP_SIZE];
> int ret;
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index abb5ad4eef5f..be740fb72ebc 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -581,7 +581,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct
> intel_connector *connector,
> &connector->base.display_info.luminance_range;
> struct intel_dp *intel_dp = intel_attached_dp(connector);
> struct intel_panel *panel = &connector->panel;
> - u16 current_level;
> + u32 current_level;
> u8 current_mode;
> int ret;
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c
> b/drivers/gpu/drm/nouveau/nouveau_backlight.c
> index a3681e101d56..a430ee30060e 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
> @@ -247,7 +247,7 @@ nv50_backlight_init(struct nouveau_backlight *bl,
>
> if (nv_conn->type == DCB_CONNECTOR_eDP) {
> int ret;
> - u16 current_level;
> + u32 current_level;
> u8 edp_dpcd[EDP_DISPLAY_CTL_CAP_SIZE];
> u8 current_mode;
>
> diff --git a/include/drm/display/drm_dp_helper.h
> b/include/drm/display/drm_dp_helper.h
> index 39d644495f3e..62be80417ded 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -851,7 +851,7 @@ int
> drm_edp_backlight_init(struct drm_dp_aux *aux, struct
> drm_edp_backlight_info *bl,
> struct drm_luminance_range_info *lr,
> u16 driver_pwm_freq_hz, const u8
> edp_dpcd[EDP_DISPLAY_CTL_CAP_SIZE],
> - u16 *current_level, u8 *current_mode, bool
> need_luminance);
> + u32 *current_level, u8 *current_mode, bool
> need_luminance);
> int drm_edp_backlight_set_level(struct drm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl,
> u16 level);
> int drm_edp_backlight_enable(struct drm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl,
> --
> 2.34.1
