Hi Sebastian,
I added a few remarks below.
[...]
> + while (remain > 0) {
> unsigned int count =
> min_t(unsigned long, remain, ARRAY_SIZE(stack));
> unsigned int copied;
> -
This separating newline prevents cluttering, so please revert it.
> /*
> * This is the fast path and we cannot handle a pagefault
> - * whilst holding the struct mutex lest the user pass in the
> - * relocations contained within a mmaped bo. For in such a case
> - * we, the page fault handler would call i915_gem_fault() and
> - * we would try to acquire the struct mutex again. Obviously
> - * this is bad and so lockdep complains vehemently.
> + * whilst holding the struct mutex lest the user pass in
> + * the relocations contained within a mmaped bo. For in
> + * such a case we, the page fault handler would call
> + * i915_gem_fault() and we would try to acquire the
> + * struct mutex again. Obviously this is bad and so
> + * lockdep complains vehemently.
I think you could leave the comment as is, because you do not
modify its contents. Furthermore, this modification changes git
history for these lines.
The rest of the patch looks good.
---
Best Regards,
Krzysztof
