-----Original Message-----
From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Gustavo
Sousa
Sent: Thursday, July 17, 2025 1:59 PM
To: intel-gfx@lists.freedesktop.org
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>; Sousa, Gustavo
<gustavo.so...@intel.com>
Subject: [PATCH] drm/i915/display: Remove unused declarations of intel_io_*
>
> Declarations for both intel_io_mmio_fw_write and intel_io_reg_write
> where added with commit 01389846f7d6 ("drm/i915: Plumb 'dsb' all way to
> the plane hooks"), but they never got used. Let's remove them.
>
> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
> Signed-off-by: Gustavo Sousa <gustavo.so...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_types.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> b/drivers/gpu/drm/i915/display/intel_display_types.h
> index
> ce45261c4a8f4299293dd9dc485e63139d29063a..76cff5548b98fc9617effffe8a6067255eca5c7b
> 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -941,10 +941,6 @@ struct intel_csc_matrix {
> u16 postoff[3];
> };
>
> -void intel_io_mmio_fw_write(void *ctx, i915_reg_t reg, u32 val);
> -
> -typedef void (*intel_io_reg_write)(void *ctx, i915_reg_t reg, u32 val);
> -
Yeah, these don't look like they're being used anywhere else in the code. If
we plan on
filling out and using these functions later, then we can just redefine them at
that point, IMO.
Reviewed-by: Jonathan Cavitt <jonathan.cav...@intel.com>
-Jonathan Cavitt
> struct intel_crtc_state {
> /*
> * uapi (drm) state. This is the software state shown to userspace.
>
> ---
> base-commit: 6cb329ec28293e8b9e670b09611149c05223dca0
> change-id: 20250717-drop-unused-intel_io-declarations-dfa7f1c0fa14
>
> Best regards,
> --
> Gustavo Sousa <gustavo.so...@intel.com>
>
>
