Re: [PATCH 2/2] drm/i915/connector: make intel_connector_init() static

[Dibin Moolakadan Subrahmanian]

On 29-07-2025 16:47, Jani Nikula wrote:

intel_connector_init() is only used in intel_connector.c. Make it
static.

Signed-off-by: Jani Nikula<jani.nik...@intel.com>

Looks good to me.
Reviewed-by: Dibin Moolakadan 
Subrahmanian<dibin.moolakadan.subrahman...@intel.com>

---
  drivers/gpu/drm/i915/display/intel_connector.c | 2 +-
  drivers/gpu/drm/i915/display/intel_connector.h | 1 -
  2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_connector.c 
b/drivers/gpu/drm/i915/display/intel_connector.c
index 42c923f416b3..6a55854db5b6 100644
--- a/drivers/gpu/drm/i915/display/intel_connector.c
+++ b/drivers/gpu/drm/i915/display/intel_connector.c
@@ -77,7 +77,7 @@ void intel_connector_cancel_modeset_retry_work(struct 
intel_connector *connector
                drm_connector_put(&connector->base);
  }

-int intel_connector_init(struct intel_connector *connector)

+static int intel_connector_init(struct intel_connector *connector)
  {
        struct intel_digital_connector_state *conn_state;

diff --git a/drivers/gpu/drm/i915/display/intel_connector.h b/drivers/gpu/drm/i915/display/intel_connector.h

index aafb25a814fa..0aa86626e646 100644
--- a/drivers/gpu/drm/i915/display/intel_connector.h
+++ b/drivers/gpu/drm/i915/display/intel_connector.h
@@ -14,7 +14,6 @@ struct i2c_adapter;
  struct intel_connector;
  struct intel_encoder;

-int intel_connector_init(struct intel_connector *connector);

  struct intel_connector *intel_connector_alloc(void);
  void intel_connector_free(struct intel_connector *connector);
  void intel_connector_destroy(struct drm_connector *connector);