> -----Original Message-----
> From: Intel-xe <intel-xe-boun...@lists.freedesktop.org> On Behalf Of Jouni
> Högander
> Sent: Wednesday, 27 August 2025 9.08
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Hogander, Jouni <jouni.hogan...@intel.com>
> Subject: [PATCH] drm/i915/psr: Panel Replay SU cap dpcd read return value
>
> Currently return value of drm_dpcd_readb is not checked when reading sink
> Panel Replay Selective Update capabilities.
>
> Fix this and switch to drm_dpcd_read_byte.
>
Reviewed-by: Mika Kahola <mika.kah...@intel.com>
> Signed-off-by: Jouni Högander <jouni.hogan...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 8b4cdf9b30db..f2b9a733637a 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -494,12 +494,14 @@ static u8 intel_dp_get_su_capability(struct intel_dp
> *intel_dp) {
> u8 su_capability = 0;
>
> - if (intel_dp->psr.sink_panel_replay_su_support)
> - drm_dp_dpcd_readb(&intel_dp->aux,
> - DP_PANEL_REPLAY_CAP_CAPABILITY,
> - &su_capability);
> - else
> + if (intel_dp->psr.sink_panel_replay_su_support) {
> + if (drm_dp_dpcd_read_byte(&intel_dp->aux,
> + DP_PANEL_REPLAY_CAP_CAPABILITY,
> + &su_capability) < 0)
> + return 0;
> + } else {
> su_capability = intel_dp->psr_dpcd[1];
> + }
>
> return su_capability;
> }
> --
> 2.43.0
