Hi Jonathan, On Thu, Sep 04, 2025 at 07:30:42PM +0000, Jonathan Cavitt wrote: > In active_engines, if intel_context_create fails, we need to go > backwards through all the created contexts to free/put them. However, > the way this is currently performed skips the first created context, as > if count == 1, then --count returns 0 and exits the while-loop > prematurely without performing the intel_context_put on context 0. > > Fix this by post-decrementing count in the while-loop, rather than > pre-decrementing it. This change makes the prior guard against count > underflowing unnecessary, as the while-loop exits when count == 0. > > Signed-off-by: Jonathan Cavitt <jonathan.cav...@intel.com> > Cc: Krzysztof Karas <krzysztof.ka...@intel.com> > Cc: Andi Shyti <andi.sh...@linux.intel.com> > Cc: Sebastian Brzezinka <sebastian.brzezi...@intel.com>
reviewed and merged to drm-intel-gt-next. Thanks, Andi