On Mon, 15 Sep 2025, Ilpo Järvinen <ilpo.jarvi...@linux.intel.com> wrote:
> PCI core provides pci_rebar_size_supported() that helps in checking if
> a BAR Size is supported for the BAR or not. Use it in
> i915_resize_lmem_bar() to simplify code.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvi...@linux.intel.com>
> Acked-by: Christian König <christian.koe...@amd.com>
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
and
Acked-by: Jani Nikula <jani.nik...@intel.com>
for merging via whichever tree is convenient.
> ---
> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> index 51bb27e10a4f..69c65fc8a72d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> @@ -61,16 +61,12 @@ static void i915_resize_lmem_bar(struct drm_i915_private
> *i915, resource_size_t
> current_size = roundup_pow_of_two(pci_resource_len(pdev,
> GEN12_LMEM_BAR));
>
> if (i915->params.lmem_bar_size) {
> - u32 bar_sizes;
> -
> - rebar_size = i915->params.lmem_bar_size *
> - (resource_size_t)SZ_1M;
> - bar_sizes = pci_rebar_get_possible_sizes(pdev, GEN12_LMEM_BAR);
> -
> + rebar_size = i915->params.lmem_bar_size *
> (resource_size_t)SZ_1M;
> if (rebar_size == current_size)
> return;
>
> - if (!(bar_sizes & BIT(pci_rebar_bytes_to_size(rebar_size))) ||
> + if (!pci_rebar_size_supported(pdev, GEN12_LMEM_BAR,
> +
> pci_rebar_bytes_to_size(rebar_size)) ||
> rebar_size >= roundup_pow_of_two(lmem_size)) {
> rebar_size = lmem_size;
--
Jani Nikula, Intel
