On Fri, Sep 26, 2025 at 02:02:52AM +0200, Andi Shyti wrote:
> From: Andi Shyti <[email protected]>
> 
> Return the actual error code from vfio_set_irqs_validate_and_prepare()
> instead of always collapsing to -EINVAL. While the helper
> currently returns -EINVAL in most cases, passing through the real
> error code is more future-proof.
> 
> While at it, drop the stray 'intel:' prefix from the error
> message.
> 
> Signed-off-by: Andi Shyti <[email protected]>
> ---
>  drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c 
> b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 69830a5c49d3..450a4673c542 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1367,8 +1367,8 @@ static long intel_vgpu_ioctl(struct vfio_device 
> *vfio_dev, unsigned int cmd,
>                       ret = vfio_set_irqs_validate_and_prepare(&hdr, max,
>                                               VFIO_PCI_NUM_IRQS, &data_size);
>                       if (ret) {
> -                             
> gvt_vgpu_err("intel:vfio_set_irqs_validate_and_prepare failed\n");
> -                             return -EINVAL;
> +                             
> gvt_vgpu_err("vfio_set_irqs_validate_and_prepare failed\n");
> +                             return ret;
>                       }
>                       if (data_size) {
>                               data = memdup_user((void __user *)(arg + minsz),

No problem for that.

Reviewed-by: Zhenyu Wang <[email protected]>

Reply via email to